It depends. If I apply the pattern to a huge part or all the canvas I use the fill layer mostly because it auto expands when you grow the canvas and you can also adjust the pattern’s parameters (like zoom, angle and scew) later on. But you could also bucket fill just a selection if that’s enough for you.