5.2.5 lockup after using Transform Tool on a group with passthrough enabled

Hi ~ just wondering if anyone else is seeing some issues with the transform tool since the update?

[Edit:Add by AhabGreybeard: Yes, it looks like a bug. See later.]

I’m on a Suface PC (Interl(R) 2.6GHz, 8GB RAM, x64, Windows 10 Pro version 22H2) — and while the transform of groups was sometimes slow in the past, it now seems to stall the app completely. The modal opens up and the progress bar remains empty - I can’t cancel or do anything at all…

just wondering if it’s just me ~ and pondering on whether I need to go back to the older version.

I’ve changed the category of your topic.

Do you mean the upgrade to version 5.2.5?

I’ve just run 5.2.5 on Windows 10 Pro on a very old desktop PC and used a simple group of 3 paint layers.
The Transform Tool was very fast when using all transform types.

Do you have a group with a particularly complicated internal structure and content?
Can you show a full screen screenshot with the Layers docker fully visible?

hi, thanks for the category change ~ had a feeling I posted in the wrong place.

And yes, sorry - I meant the recent update to 5.2.5 — here’s a screenshot of my current file - with the group selected to transform and the full interface visible.

I don’t think it’s anything complicated or particularly odd - it’s a simple shape, similar on all layers, grouped to move and scale ~ but as soon as I do anything, even just moving it or trying to reflect it, the app hangs, stalls ~ and I cannot even get out of it via cancelling the transform action.

PS: also seeing some oddities in the docker for the touch screen control which scales them to very tiny (as visible, lower left) and it keeps misbehaving too…

hello again, just did another test run - and it seems the transform works fine without the pass through enabled.

so in my screenshot - that group that’s selected worked fine for a transform just now. But the group below, the one with the pass through set causes the hanging and will not allow the transform. I often group elements, and usuall always set the pass through to show the applied layer modes of the grouped layers and it does not affect the transforms usually. It is sometimes a little slow, if I have many layers - or a large numebr of varied layer modes - but it would always work, and let me cancel the process too.

I agree.

I can’t think why the ‘shape’ group having pass through enabled would affect transform operations on the ‘leaves’ group which is above it.

Can you make the .kra file available using a link to a file sharing service?
If you’d prefer not to share it with the world, you could send me a DM with a download link in it. If you do, I can’t commit to checking it quickly.

I’ll try looking at that next time even though I don’t have a touch screen.

Which version was the older version?

To try an older version, here is the portable .zip of 5.2.3:
https://download.kde.org/stable/krita/5.2.3/krita-x64-5.2.3.zip

and here is the portable .zip of 5.2.2:
https://download.kde.org/Attic/krita/5.2.2/krita-x64-5.2.2.zip

1 Like

Thank you so much for your reply and for looking into this ~ much appreciated ツ

Hopefully this link will work: terra_nostra_singula_274.kra

And the shape group of the leaves works fine now - but if I try to transform the group called ‘shape’ ~ this is when the problem occurs.

And thank you very much for the links to the older versions, I will try to go back to those if need be.

1 Like

That link downloads and the .kra file opens with no problems.
I’ll try to look at it later.

1 Like

excellent ツ glad the link worked ツ

and thank you very much already for your help ツ

I’ve changed the category (again) and changed the title.

Advisory ping to @dkazakov

This is a bug. I’ve tried it with the Linux appimage 5.2.3 and 5.2.5.
I’ve tried it with Windows 10 with 5.2.3, 5.2.4 and 5.2.5.

5.2.3 and the 5.2.4 Windows version (not available as an appimage) have no problem.

5.2.5 has a lockup when doing Apply after performing simple transforms on the ‘shape’ group layer when its pass through is enabled.

With Windows, when locked up, one CPU is at 100%.
You can do File → Quit and it asks if you want to save changes.
Say No, it shows a progress bar saying an operation is in progress: Transform.
You have to End the process to stop it.

With Linux, when locked up, one CPU is at 100%.
You can do File → Quit and it asks if you want to save changes.
Say No. It quits with no hesitation.

With the ‘shape’ group layer pass through turned off, there is no problem.

I simplified the document by removing layers I thought would be ‘insignificant’ to give the following layer structure:

To my surprise, that one did not lock up.

Thinking it might be a size/complexity problem, I scaled down the original from 3k x 3k pixels to 1k x 1k pixels but that still locked up.

I’m thinking about trying to replicate all this with a newly made test document.
Maybe someone else has ideas too.

I can reproduce the issue in a document with two group layers in passthrough mode.

It seems to be a regression of Fix Move and Transform tool to work with Pass-Through groups (c2c12c46) · Commits · Graphics / Krita · GitLab

Apparently, the lower passthrough group gets stuck in a while loop in KisImage::refreshGraphAsync(). (The upper passthrough group doesn’t enter the while loop at all.) If !leaf->shouldBeRendered(), the loop is infinite, because leaf is never updated.

while (leaf) {
    // ...
    if (!leaf->shouldBeRendered()) continue;
    // ...
    leaf = leaf->nextSibling();
    // ...
}

Since this is a bug (a rather serious one at that), it should be reported.


The Touch Docker does have issues with attempting to scale the icons to the available space in a bizarre way. Though it was rewritten recently, I guess it’s not a regression, since there’s an old bug report that seems related: bug 392583 – Illegible touch docker icons

2 Likes

@freyalupen, I’ve made a bug report here:
493774 – Lockup crash using Transform Tool on a group that has pass through enabled
I’ve quoted you in it.

Please Confirm it and give any further details you feel would be useful.

@AhabGreybeard & @freyalupen
thank you so much for following up on this - I have tested it all some more, and when I disable the pass through, there are no issues at all ~ so does seem to have something to do with that.

And good to know that the touch docker icon issue is already known.

Thanks again ツ

1 Like

Hi, all!

Could you please check if the packages built by this pipeline fix the issue (they are still running):

Pipeline · Graphics / Krita · GitLab

UPD1: Here is a direct link to the Windows package: https://invent.kde.org/graphics/krita/-/jobs/2160124/artifacts/raw/krita-x64-5.2.6-prealpha-e543348d.zip

UPD2: Direct link to a Linux pacakge: https://invent.kde.org/graphics/krita/-/jobs/2160706/artifacts/raw/_packaging/krita-5.2.6-prealpha-c6e5426aa1-x86_64.appimage

2 Likes

@dkazakov I’ve just tried the 5.2.6-prealpha (git e543348) on Windows 10 using theterra_nostra_singula_274.kra file that was provided in reply above.

That no longer locks up when I do multiple and repeated transforms on the group that has passthrough enabled.

I also tried adding passthrough to the group above it as well and that gave no problems with transforms.

It’s looking hopeful so far :slight_smile:

4 Likes

Hi ツ

sorry about the delay - just tested it ~ and same result, all working fine. Tested it on another, more layer-heavy and complex file (more layers in group, all with changed layer modes + pass through enabled on group) ~ and it still worked very well - quick preview and no hanging at all! yay ツ ツ ツ

2 Likes

Hi, all!

Could you quickly test these packages for Krita 5.2.6? If they work fine for you, we will make an emergency release tomorrow: KDE - Experience Freedom!

What need to be tested:

  1. If the bug in the this thread is really fixed
  2. Animation Audio works fine (especially on Linux and MacOS platforms)
  3. Animation export to a video file (e.g. MKV) works using the embedded FFMpeg (especially on Linux and MacOS platforms)

@dkazakov I’ve just tried the appimage with transforms on passthrough groups and it’s fine.

I’ll try animation audio on Linux and Animation Export with the embedded FFMpeg tomorrow.

However, I seem to be one of those lucky people who never had a problem with animation audio on Linux and I’ve already used the embedded FFMpeg with no problems so I’m probably not the best person to test those.

Edit:Update: I imported an .mp3 file that was much longer than a 58 second animation that I have.
It played well and rendered out, using the embedded FFMpeg, to .mkv and .mp4 with the audio playing fine.
Further testing by people who’ve previously had problems would be good to have.

1 Like

hi ツ

I just tested the 5.2.6 version ~ opened up a few of my art files which are complete and quite complex with lots of layer as well as groups and so on. I tested the transform on various groups, with and without the pass through enabled ~ and very happy to report this is all working perfectly.

In fact, I think this now works better than ever before ツ ツ
The preview of any transform action is fast and the transform so smooth and super quick too. So to me and going by my last test runs, this does seem to be fixed now.

Sorry I can’t help with testing the animation - I don’t have the time to try this out as I have not used Krita for animation before.

Thank you all so much for the quick follow-up and solution ツ ツ ツ

3 Likes

This topic was automatically closed 4 days after the last reply. New replies are no longer allowed.