Can you check is it fixing bug1 and bug2 if just to place empty non-clipped layer on the top of group layer?
I guess it could be incorrect clipped nodes validation for cases when group has clipped layer on the top.
Can you check is it fixing bug1 and bug2 if just to place empty non-clipped layer on the top of group layer?
I guess it could be incorrect clipped nodes validation for cases when group has clipped layer on the top.
Yes, it worked, even the layer is invisible.
Fine! I will make fix soon.
So, here is fixed version, now topmost clipped layers in group and project should not break projection rebuild. Please let me know does this fix help?
Linux appimage:
https://github.com/uvhat/krita_clipping_layers/releases/download/krita_clipping_layers_5_3_2_1_c15/krita-5.3.2.1-97e88e6e23-x86_64_c15.AppImage
If you will find any bug related to clipping or other mods please let me know!
Description and diffs:
Yes, it fixed that two bugs. I will keep using it.
May I suggest having a feature that exports KRA files that uses alpha inheritance layers into PSD files but converts alpha inheritance layers into clipped layers?
Have you touched KPConvert ? it is simple converter psd to kra and back as standalone tool.
I’ve never heard about it before but I just tried it out. KRA to PSD doesn’t seem to work unfortunately.
New update for build of Krita clip layers 5.3.2.1 c17
Linux AppImage:
https://github.com/uvhat/krita_clipping_layers/releases/download/krita_clipping_layers_5_3_2_1_c17/krita-5.3.2.1-3983083d1e-x86_64_c17.AppImage
Android arm64-v8a (test):
https://github.com/uvhat/krita_clipping_layers/releases/download/krita_clipping_layers_5_3_2_1_c17/krita-arm64-v8a-5.3.2.1-1b0468c1d0-debug-c17.apk
There is fixed styles rendering and composition for clipped layers and base layers.
If you don’t care about styles - you can skip it. (For example, i never use styles and don’t see any practical case for them - all their effects can be recreated by usual clipping/IA layers, masks, overlays and other things).
It is a bit different from vanilla krita styles rendering for styles of base layer with inherit alpha layers above, read description for this here:
Using @radian-art approach becomes very messy and complicated… Need to think to remake everything related to clipping through native async merger and walker approach.
If you feel something is broken, let me know! For example, i’m still not very sure about Instant Preview mode (for drawing and for transform tools), it could make something wrong when working with base layer or whole clipping groups ( i tested it a lot in previous builds, it seems works fine, but still no sure).
Hey, there’s this ticket((?) dunno its name in English) about how to implement the clipping mask, maybe y’all could brainstorm together?
They’re probably on IRC chat, but still…
Hi!
I know about this ticket and looking on it periodically (but for now it has no updates, just draft ticket, clipping support is not main thing of Krita for now - they i think are very busy with moving things to Qt 6 and other major changes). I hope they understand well the difference between a clipping group and a simple clip mask - filters, effects, composition modes should be isolated to clipping group projection, not just simple alpha copy from base layer.
My work more just for personal fun and for build working concept how it could work with related UI changes and some nuances about how clipping should work with masks, styles, filters layers and other non-obvious things that differ from how IA works under the same conditions.
In parallel i researched how async merger/walker working and some things about it, and in general i have now rough plan what to do.
Awesome, layer styles (especially the strokes option) is extremely convenient for comics so glad you made a version that’s compatible!
Just chiming in to voice my support for this feature!
I think it’s great for it to work with Styles as well – when I use Clip Studio, I miss the styles feature so it’s good to have in Krita ![]()
Great to see updates! Gonna run some tests now!
I ran into a few bugs by chance when using the merge feature across multiple clip layers. You can check the video link below for details. The version I’m using is krita-x64-5.3.2.1_clip_5_3_2_1__c17.zip.
Hi! Got it, i working on migrating clip merger branch to separate file from native applyImpl(), will look on this bug too! looks like it quite simple task, just need disable clipping for merge time and set clipping back to resultet layer.
New update for build of Krita clip layers 5.3.2.1 c21 - > c23 → c25
Fix race condition on large images for clip group caching. Please download 25 instead of previous
Win64:
Linux AppImage: https://github.com/uvhat/krita_clipping_layers/releases/download/krita_clipping_layers_5_3-2_1_c25/krita-5.3.2.1-208f54be4c-x86_64_c25.AppImage
Android arm64-v8a (test): vip
Info: Release krita_clipping_layers_5_3-2_1_c25 · uvhat/krita_clipping_layers · GitHub
Please try this. I fixed staled cache of clipping group after reordering of layers, and clipped layer selected merger. This still utilises older code of clip merger in the applyImpl() of kis_layer_projection_plane class. Migrating to async merger still in process.
In new 23 - fixed race condition for projection cache of clipping group update, on large canvases it could update only left top tile only.
If you feel caching is not correct on some operations or commands, you can disable it by in-name config in Layer 1 like:
Layer 1 _cl_conf _cl_no_cache
Also, found an issue with vanilla Krita selected merger - if we selected few layers including filter layer and try to merge it - the result will contain projection of filter layer which incliude all layers below filter layer, even not selected. This is kinda bug. For clipped layers - i fixed this issue for selected layers from the same clipping group. But for selection from different and many clipped groups it keep default weird behavior of vanilla Krita.
Small bugfix for race-condition on large canvas on layer reordering, pls try update ^^^^^^^^
Thanks for your hard work, I tested it, and found some bugs. I’ve uploaded the video.
Can you describe this issue? don’t get it from video. Do you try to use merge with previous layer? Did you try “merge selected” ?