I can see and check “draft” option when MR is created.
But once it’s created, it seems I don’t have the option available anymore ![]()
Grum999
I can see and check “draft” option when MR is created.
But once it’s created, it seems I don’t have the option available anymore ![]()
Grum999
Hi, @Grum999!
Once your MR is created, you can just edit its title and Draft: or WIP: prefix and the merge request will be blocked from merging automatically.
Your patch is perfectly fine for master, since no format-UIX-related changes are planned. For the icons, please open another MR and we will merge it right away. It is easier to merge a small MR then you recheck an already checked MR for us developers ![]()
Ok thanks!
I’ll try to do that for next MR for which feedback are requested here ![]()
The icon change will be applied&MR once poll will close, then next Wednesday or Thursday according to my availability
Grum999
@Grum999 btw it would be great if you can write the doc for the features you add as well.
Yes for sure!
But in the process, I think first the MR for code should be accepted and applied (and in my case both MR then)
After, how it’s synchronized between code and doc?
To be sure the documentation is not updated and published before the new functionality?
Grum999
Wen the features get merged, then you make a mr for the doc repo. If you cannot add it for whatever reason then it becomes another job that the krita team has to do. It’s not in a hurry, if the feature will be in the next release, say, 5.3, then you have time, but it is easy to forget.
Hi
I started to look to update the documentation.
(I’ve already updated the Dockers/Layers page to inform about new icon)
I’m a little bit surprised by the page related to Vector Layers which is accessible from Layers and Masks.
It’s indicated the page is outdated, and recommend to look at Vector Graphics page which is from my point of view not so “up to date” and even less complete…
Why creating a new page instead of updating the existing one?
My idea here is to update properly the Vector Layers page which is (from my point of view) the most important one, updating what is outdated and taking in account what is on Vector Graphics and not in Vector Layers.
Does it makes sense?
Grum999