Hey everyone, last few days I finally built the source code for Krita on Windows , and was playing around with the thing which was annoying to me for a while - static actions cannot have user-defined icons.
I found https://bugs.kde.org/show_bug.cgi?id=376101, where was mentioned that this feature was actually in Krita before 2014, but I couldnât find any source code for that so did my own implementation.
My big first question for now is this: is it something which is worthy for a pull request?
I still need to work on this, like test it on mac, linux and android (have all 3, no idea yet how to build it for these platforms ), maybe think of some âresetâ button etc.. So if it likely to be approved, better I drop this idea now and wonât be so sad as if I spent more time performing a NINJA-PR, surprising everyone and finding out that this is going to be rejectedâŠ
P.S. icons are saving OK, and I made it that way so these custom icons are reflected even on app close and open. There is no turning back to default icon â I didnât think that far ahead yet.
Hi @shlop_op . Does it mean you already have an implementation on Windows and itâs working okay as far as youâre concerned? I see your screenshot shows the button thatâs normally not there.
If yes â then I think itâs fine to go ahead and open an MR and ask for feedback there. That should not be too much work at this point. If the response is positive, you can go ahead and test the change on other platforms and polish it to make it through the review.
I see the bug you linked is CONFIRMED, meaning itâs a problem that was already acknowledged. Based on that, the fix probably wonât be rejected without a clear reason.
For other cases where you donât have the change ready yet, you can get in touch with the developers via IRC and ask if working on something is a good idea. You can find the contact info in the official docs: Introduction to Hacking Krita â Krita Manual 5.2.0 documentation
Hi everyone, thanks for responding! @Michelist I donât have a background of C++ and Krita, but I just follow the existing code . I downloaded the windows Qt6, but the app closes after loading popup, not sure why. Anyway the conflicts with new version will be known from the code side I hope.
@sooz Exactly! I bought an Android tablet and tried krita on it, thatâs where it hit me - because I had so many actions in my toolbar on PC without icons. And I wasnât paying attention because my screen is huge 32â, but even large galaxy tab s10 ultra couldnât show all of them.
Try disabling the News on the welcome page (itâs a known bug).
Your changes will likely work fine on Qt6 and all platforms (but I havenât checked).
, and was playing around with the thing which was annoying to me for a while - static actions cannot have user-defined icons.
), maybe think of some âresetâ button etc.. So if it likely to be approved, better I drop this idea now and wonât be so sad as if I spent more time performing a NINJA-PR, surprising everyone and finding out that this is going to be rejectedâŠ
Hello 