I finally be able to push change to my fork… not sure to really understand what I really did
So now, @halla I’ve made a merge request…
I tried to use the default template for a merge request, but not sure that template is really adapted for a plugin… most of checkbox are not checked because I’m not sure about what i can really do for a plugin…
After merge request has been made, I’m on this page (3 of 5 tasks completed) but I’m not sure to understand what I have to do now…
For example, what does it means?
[Rebase] Fast-forward merge is not possible. Rebase the source branch onto the target branch or merge target branch into source branch to allow this merge request to be merged.
I have to click o n the button??
Clearly I’m not easy with git and may I have to practice a little bit more…
Please note, according to this:
That plugin is not working for 4.3.0 and 5.0.0 (didn’t check yet if last build had changed something, need to test it)
Generally you don’t need to worry much about such things because you don’t have the access rights to the repository, so you won’t be able to merge…
In any case, the MR needs to be on top of the newest commit in the repository. To achieve that, you can press “Rebase” button (in git, you, being on your branch, could do: git rebase master, it would do the same thing - just on your local master, so first you’d need to make sure your local master is up to date with the official one…). Then someone can press “Merge” button to merge it into the official repository to master.
If you don’t want to worry about that, just make sure that the checkbox “Allow people with push access to make commits in your branch” or something like that is checked, then we can do both Rebase and Merge. Also “Rebase” is good to be done just before merging, there is often no point in doing it before that.
I tried the git rebase master but the only thing I had was a message to told me that everything is already up to date…
I think I missed this detail:
And I made the push without having my branch synchronized…
I don’t think it’s a big problem because I’m working on new files/directory, but I will try to update my local master with the official one as soon as possible and redo the rebase.
Unfortunately, computer on which I usually code and draw (I currently use my laptop to write this comment…) have violently crashed and I can’t use it for now (currently doing controls of disk on which OS is installed)…
I hope to be able to finalize actions tomorrow (crash occurred while I was running a compilation of Krita to validate that Dmitry patch solve the problem - I think it’s ok but I want to do it by myself )
Hello, I deeply apologies for reviving this thread, but’ I’ve encountered big problem with this plugin for some time (maybe a month or so), probably since downloading new (5.1.1) Version of Krita
Again, I apologize if I posted in a wrong place.
Preface:
Krita Version: 5.1.1
OC: Windows 10 Pro
Problem:
When I run this plugin, instead of getting 3 layers in 3 color modes (Copy Blue, Copy Red, Copy Green) I get all three layers in Addition mode.
Re-installing Krita as well as downloading this plugin for here didn’t fix the problem. (Instead, I now have two plugins of the same name and function in my Python list).
I’m no specialist in writing code, but while reading code posted here I did notice that for RGB parts there was such writing:
Python 3.8.1: C:\Program Files\Krita (x64)\bin\krita.exe
Sat Oct 15 14:18:46 2022
A problem occurred in a Python script. Here is the sequence of
function calls leading up to the error, in the order they occurred.
SystemError: PyEval_EvalFrameEx returned a result with an error set cause = KeyError(‘channels2layers’) class = <class ‘SystemError’> context = KeyError(‘channels2layers’) delattr = <method-wrapper ‘delattr’ of SystemError object> dict = {} dir = doc = ‘Internal error in the Python interpreter.\n\nPleas…ersion, and the hardware/OS platform and version.’ eq = <method-wrapper ‘eq’ of SystemError object> format = ge = <method-wrapper ‘ge’ of SystemError object> getattribute = <method-wrapper ‘getattribute’ of SystemError object> gt = <method-wrapper ‘gt’ of SystemError object> hash = <method-wrapper ‘hash’ of SystemError object> init = <method-wrapper ‘init’ of SystemError object> init_subclass = le = <method-wrapper ‘le’ of SystemError object> lt = <method-wrapper ‘lt’ of SystemError object> ne = <method-wrapper ‘ne’ of SystemError object> new = reduce = reduce_ex = repr = <method-wrapper ‘repr’ of SystemError object> setattr = <method-wrapper ‘setattr’ of SystemError object> setstate = sizeof = str = <method-wrapper ‘str’ of SystemError object> subclasshook = suppress_context = True traceback = None
args = (‘PyEval_EvalFrameEx returned a result with an error set’,)
with_traceback =
The above is a description of an error in a Python program. Here is
the original traceback:
KeyError: ‘channels2layers’
The above exception was the direct cause of the following exception:
SystemError: PyEval_EvalFrameEx returned a result with an error set
Thank you in advance for help and additional thank you, Grum999, for creating this to begin with.
Yes it’s seems plugin is not working anymore since Krita 5.1
Just tested 5.0.6, plugin works as expected.
If you’re using the plugin 98% of time, I an only recommend you to go back to Krita 5.0.6 until a fix has been made.
I’ve to dig why it doesn’t work anymore, but from memory I already got a similar bug here:
I’ll try to check in the week if it’s the same problem or not
I would be nice if this script could be made to work in the latest version, I could use this in combination with the Halftone filter to make color screen tone comic book separation style. With the amount of back and forth trying to get the correct resolution and dot density, having to go back and forth between versions of Krita also is just an roadblock.
From developer’s feedback, I’ll update plugins.
Can’t say exactly when I’ll be able to fix this, will try to manage this quickly
Concerning newspaper plugin, I’ve opened a bug in github:
For Channels to Layers, as it’s now a part of Krita, an official bug has been created: https://bugs.kde.org/show_bug.cgi?id=461147 (note: patch to fix bug is provided with bug declaration )
)