"Close gap" in Fill tool

[Eranthis_stellata]

@KIO

Hello.
Have you seen this topic?
I am also very excited about the development of the fill.

Enclose and Fill Tool Proposal

This is not a function with the same effect.
Fill color won’t overflow in lineart with “gaps”, that’s not its function.

Enclose and Fill Tool Proposal

The explanation of the tool goes like this: the tool is supposed to fill closed regions inside the enclosing region (those regions that are entirely inside the enclosing shape that the user makes). If one of the regions touches the boundary of the enclosing region, then it is not considered closed, and it is not filled. The different modes under the “what to fill” section are variants on that: all regions: fills all the regions of any color that are entirelly inside the shape made by the user…

[LunarKreatures]

While that would be a nice feature to have and would speed up work by a lot, have you tried using the colorize mask? Don’t know how well it would work in an animation setup but it can fill in lines even with gaps.

[AhabGreybeard]

The colourise mask can’t be animated, at the moment, but there is a WIP effort going on to make it possible for it to be animated:

WIP: Making colorize mask work with animation (!661) · Merge requests · Graphics / Krita · GitLab

It may be possible to incorporate the gap-filling abilities of the colourise mask into the fill tool but that would need developer comment and effort, if it could be done.

[fizzyflower]

@AhabGreybeard

It may be possible to incorporate the gap-filling abilities of the colourise mask into the fill tool but that would need developer comment and effort, if it could be done

I would like the gap detection feature from the colorize mask to the fill tool too.

[acc4]

It would not only be useful for animation, but also would be awesome for normal painting process too. It’d be even better if this was implemented in selection tool.

[tiar]

For Fill Tool with filled gaps we can steal the code or at least the mechanism from Gimp (I believe it has it implemented somewhat recently?).

For animation Colorize Mask will be easier, less clicking. Especially if there would be the functiom to replace the color which shouldn’t be that difficult to implement.

[AhabGreybeard]

The original topic post has been flagged and hidden.
Is this because of the particular character in the animation?
i.e. a copyright thing.

[Eranthis_stellata]

This is Google Translate.

The filling tool code of mypaint2 can also be referred to.

[raghukamath]

That was because automatic spam filter, the images were from the same domain and the user had posted quiet a few links to that domain.

[Isamel_Ray]

I hope something like this makes it into Krita. Using the fill tool like this would be much quicker than setting up a colorize mask.

[tiar]

For animation, Colorize Mask would be much quicker since you probably wouldn’t need to redraw the mask strokes for every keyframe (or at least, not all), but with Fill Tool, you’d have to fill it on every keyframe.

The Colorize Mask for animation is in progress though I don’t think anyone is actively working on it.

[kaichi1342]

Outside of animation, fill tool with gap closer is a good tool to have in illustration.
Setting up a colorize mask for something simple as maybe randomly filling a hand drawn square or a small area is quite a task.

Also rarely we ink with closed gaps there’s always going to be an opening , unintentionally or on purpose. I rarely use the fill tool because of this “spill”. When i ink i favor a loose scrawl over smooth ink that create a lot of tiny gaps so i mostly end up up coloring flats manually using a brush.

[Isamel_Ray]

That’s my main issue with color filter as well, it’s great in its own right but setting it up each time you want to fill something can get tedious. It basically forces you to leave filling as the last step wich isn’t always ideal, and basically locks your workflow.
I believe that having the option to use the fill tool can offer artists more freedom.
And MyPaint has a flood fill tool with close gap (scroll down for gifs - and a great drag to fill multiple regions which would be awesome to have in Krita). After the awesome work of porting the brush engine from Mypaint, I hope the devs port the fill tool as well.

[Ralek]

As an animator, I wholeheartedly agree that there needs to be a more nuanced and complex coloring system for animations (or just in general).
And if the colorize mask is the solution, please, please, add functionality to it for things like color changes without a defining line between them. Something like the ZRemesher Guide brush in ZBrush. My current workflow for color is:

• Colorize the art as best as possible
• Rasterize the colorize layer because it’s way too restrictive to color anything more complex
• Fix the inevitable bugs in the coloring
• Paint the actual color patterns over the object

Basically I just use it in place of the paint bucket and rasterize it immediately after. If you want to make it useful for animation, it needs to be flexible enough to not warrant immediately rasterizing.

Either way this has sparked my imagination of what could be possible in Krita, having seen what’s possible in the programs I use for animating professionally, so I’ll likely make a new thread with my suggestions for the colorize mask.

[Deif_Lou]

I’m probably going to propose a faster colorization algorithm this month, but not additional features yet. I think the most important thing right now is bring the colorization as close as possible to realtime. Here it is a video I made comparing my prototype with tvpaint:

test colorizer vs tv paint

[Ralek]

Could something like this theoretically work with point-based color sampling? Where instead of an input bitmap of color, it takes an array of x/y coordinates and the color values of said coordinates and colorizes it from that?

Using something like that would make keyframing the colorize mask for animation much easier and more intuitive.

[Deif_Lou]

In theory you can, but in these algorithms the size of the scribble matters, a bigger scribble has more probability of filling an area (if there are no lines in between).
For keyframing, the problem would be the same I think for points or entire scribbles if you use these type of algorithms. The scribbles are stored independently internally if I’m not mistaken, so you could move then I think. One good thing to have is an option to extrapolate the scribbles to the next frames in a content aware fashion. Then you just would have to tweak the results here and there without full keyframing.
Also a good bucket fill that can fill in various frames at the same time with one click is interesting.

[EyeOdin]

if instead of a skribble it was a point would it not be easier to animate that QPoint over in an animation and make like a colorize filter over animation over tons of frames faster?

ussually I suggest this idea with the concept of emptys in Krita.

[TheTwo]

It looks good and fast! I hope it can maintain this speed even in more complex environments. Although 5.0 has not yet arrived, I have already started to look forward to 5.1…
In addition, I want to be able to change the color in the color palette instead of re-painting.

[Deif_Lou]

@EyeOdin

if instead of a skribble it was a point would it not be easier to animate that QPoint over in an animation and make like a colorize filter over animation over tons of frames faster?

By the nature of the algorithm, which uses an intermediate graph, formed by the image and the scribbles, using a point would be the same as a 1x1px scribble.
It is as easy to animate a point as it is to animate the position of a scribble.
If you want points you just use small dots. But in the end I think you would end up using too many dots to satisfy the colorization you want.