Call for Krita UI Redesign Plugin Testers

Thank you all for your response.

Due to my lack of English language skills, I am confused.
There is nothing I can do.

krita is a great software. Thank you very much.

I will evolve to be as good as krita.
I will study English.
Then the problem will be solved.

Thank you for the consultation.

We already have a bug report: https://bugs.kde.org/show_bug.cgi?id=427675 so don’t worry, we’re trying to fix the issue.

Thank you! @boud

I’ve been looking into the bug for a little bit, but a doubt has arisen. Where are the translations stored when cloning the repo @halla ? I’ve searched for “subexposicao”, which is a portuguese term included in the blending modes, but I couldn’t find that anywhere in the repo.

Also, this bug doesn’t happen in Portuguese, so I’m intrigued. The brushes box appears to be correct, which adds more to the strangeness.

essa palavra nao leva traço? “sub-exposicao”
percebo a falta de til e cedilha mas o traço parece internacional o suficiente para ser incluido se for assim que se escreve.

Short answer: Nowhere, because translations are not in the git repository (yet, at least).

They are in the SVN repo for KDE translations, and they are somewhat scattered because the repo is divided by language at the top level, and then by app below (which makes sense from the point of translators, but is not so convenient for us developers)

But boud recently created a Python script as part of this merge request that fetches the translation files:

It worked fine for me to download all the files into the po/ subdirectory, you just need to rerun CMake so it gets detected and added to the build targets.

É possível que seja estranho, mas o estranho é mesmo o bug em si :smiley:

Question, how did you know what was the name of the Widget? I’m trying to fix the bug right now, but struggling a bit!

Small python example of walking through Qt Object tree, and printing out all instances of QDockWidget (all krita dockers inherit QDockWidget)

from krita import Krita
from PyQt5.QtWidgets import QDockWidget

def walk(q_obj):
    stack = [(q_obj, 0)]
    while stack:
        cursor, depth = stack.pop(-1)
        yield cursor, depth
        stack.extend((c, depth + 1) for c in cursor.children())
        
app = Krita.instance()
q_win = app.activeWindow().qwindow()

for w, d in walk(q_win):
    indent = d * "  "
    type_name = type(w).__name__
    obj_name = w.objectName()
    meta_name = w.metaObject().className()
    if isinstance(w, QDockWidget):
        win_title = w.windowTitle()
        print(f"{indent}{type_name=}, {meta_name=}, {obj_name=}, {win_title=}")

/AkiR

That was what I needed, thanks!

Yup, fixed for all languages, pushing the update now :slight_smile:

I’ll keep working on this for the coming weeks to see if I can have a newer version ready for you guys by Christmas :smiley:

I have to say that seeing this plugin work well on translated krita, and all the buttons having the right size was very pleasant. Big thanks for spending this time on bug fixes :slight_smile:

I’m only doing it because you guys are awesome, and it feels great to be a part of this community :smiley: If I can do anything to improve this awesome tool, then it’s time well spent!

cool thank you!!!

Thank you for the amazing work! :grin:
Encountered this bug, did not crash Krita, just showed up. Does anyone else get the same error?

Absolutely love this addon to bits! There are some things in the flat theme I think could make it even nicer, in my opinion.

How it currently is:

How I personally think it could be improved with 3 tweaks:

Removed button outlines
I think the icons without the outline are much less attention-grabbing. I feel that my eyes focus more on the canvas when the buttons have less contrasting elements. Activated buttons could still keep their shaded box. Though, there are some things I really like with the outlines! For instance elements in the UI, “OK” and “Cancel”, or dropdowns in menus, the outlines work pretty well!

Having thin lines beneath wide dropdowns
The downside of not having the outlines are elements like the Blending Mode dropdown, which kinda looked like it was floating in space without them. Therefore I think something like a line beneath, connecting the text with the dropdown arrow, would make it look like a dropdown again. It could also look nice to have the current outlines on just those elements.

Having separation lines between dockers
I think the lines above tabs can contribute making the dockers easier to identify, and visually separating them! I think the extra lines add order to the interface.

Again, thank you for all the amazing work, Pedro! :grin:

@slightlyangrydodo first of all a lot of thanks to you! I really like how this theme/addon makes Krita cleaner looking and I see that it is a lot of work.
@rakurri I totally sign the removal of the button outlines and the “split” lines between the dockers. Nice ideas!

This is great feedback, and I too personally dislike the buttons for now. I’ll try my best to make it better for the next iteration!

So here’s the latest push, done just a few minutes ago!

There is still a lot to improve, but I’m getting the hang of it :smiley:

That looks splendid! I love seeing the UI looking better and better, great work! :grin:Thank you!