Compact Brush Toggler

kaichi1342 · January 13, 2024, 2:01pm

As long as I know what’s going on and has time - If I take SchordingerCat’s bug report this had taken a long time to be resolve - which is a shame :(.

Anyway do tell me if - its working as intended in your end.

kaichi1342 · February 10, 2024, 3:33pm

Hello,

Major Update - So many changes that I decided to just go ahead and make it Ver.1.0.0:
This update take advantage the new Preset Class. This will only work for Krita ver 5.2 if you want to still use the plugin the last update for Krita 5.1 is Ver.0.1.5.

For KRITA 5.2. ONLY

Compact Brush Toggler V.1.0.0

Download: Zip File V.1.0.0

Patch Note:

Code Rewrite;
– Changed code to use Preset Class instead of walking the UI
Added Smudge Length and Smudge Mode Toggle
–
Added ability to assign shortcut key to all toggle
–
ui-brushtoggler4422×242 38 KB
Added Icons for Toggle Off State
–
image134×408 9.26 KB
Minor change in UI

Other :

There is still an issue when change in brush editor don’t reflect on it immediately and need the brush to be reloaded [deselect and re-select]

Do tell me if the new icons are recognizable .
Yeah I added a cat :3

DMY169 · February 10, 2024, 9:42pm

@kaichi1342 I am running 5.2.2 on Windows 11, getting this error message

not sure if this is what you were describing, but this appears when switching to Rakurri’s rbr) Charred brush. Haven’t tried all, but and The Flow Concept paint smooth has a message (below)

freyalupen · February 10, 2024, 10:44pm

It’s most likely the oddity with brushes with embedded patterns that I mentioned here (with workaround code): What are the possibility of the Preset class? - #8 by freyalupen

For testing, an easy way to create a brush with this problem is to save a copy of the default brush h) Chalk Details. (There are some bug reports related to doing that.)

kaichi1342 · February 11, 2024, 3:27am

Oh I see, I was thinking which one was doing it. Since i did test brushes with texture tips.
but didn’t thought that those with patterns can cause issues and i have pattern brushes but it was not trigger. I think ill go investigate of what was common to those brushes that has issues.

Thank you for the heads up. I’ll look into the code and see.
[though I have full plate today - so it gonna take about a week before i can resolve this one]

kaichi1342 · February 11, 2024, 3:34am

h) Chalk Details. (There are some bug reports related to doing that.)

This one is not causing me issues.

And I have the exact one [CBT plugin] from the git. [ I dled and reinstalled to test the git version]

@DMY169
what version of rakurris packs are those.
I have one of their packs, I dont seem to have this one.

kaichi1342 · February 11, 2024, 1:41pm

I finally acquired the charred brush .

I also tested a bunch of brushes with texture and about half o rakurris brush and I havent encounter this problem.

can you send me this specific brush from your computer.

and just in case what OS are you using?

DMY169 · February 11, 2024, 4:35pm

running 5.2.2 on Windows 11. The Rakurri set is V2.1, but I am not sure how to send a “single” brush. I had tried other similar brushes from Rakurri’s set I got no error. As I needed the brush, I deleted the program and installed 0.1.5 and have no issue. Let me reinstall 1.0.0 and see what happens

freyalupen · February 11, 2024, 4:41pm

It’s not with most textured brushes themselves, but if you modify it and save a new version, the new version will have issues. (Related bug reports: bug 456197, bug 456586, possibly others I’m forgetting) The “memileo 360light_05” and “_06” bundles have brushes with this issue however.

The issue is, what should be a bytearray gets resaved as a string.
For comparision, here’s rbr) Charred original and resaved:

<param type="bytearray" name="Texture/Pattern/PatternMD5">idji5SSzypC3T3/rq2AGlg==</param>

<param type="string" name="Texture/Pattern/PatternMD5"><![CDATA[????$?ʐ?O???1??]]></param>

where the ? are unprintable characters. The unprintable characters cause the parse error. So you’ll have to find a way to remove them before parsing the XML. Which is what my code in the post I linked earlier was trying to do, although I seem to be having issues getting it working now :/.

kaichi1342 · February 11, 2024, 11:33pm

Would it be possible to for now catch this ahead, and resave it proper format.

Like ill do 1 param loop at the end to get this property, and make sure its in bytearray before saving.

Edit: it looks like it is a bug in overwriting the preset - itself. In krita’s end.

my loadState function doesnt do any saving and just read param.

kaichi1342 · February 28, 2024, 12:09pm

@DMY169

V.0.1.6 - Compact Brush Toggler Works for 5.1 - 5.3.
– Using the UI Tree walking
– Added Shortcut
– Change Icon

Download Link

Note: this version doesn’t have Smudge Length and Smudge Mode

A temporary stop gap while im looking how to fix the bug.

karemuvar · March 14, 2024, 5:41pm

Are the changes to the brushes temporary for the session? Are they saved over thee original?

kaichi1342 · March 14, 2024, 10:46pm

Temporary for the session. They go back after krita closes and open again.

karemuvar · March 14, 2024, 10:53pm

Awesome, thanks

kaichi1342 · March 14, 2024, 11:50pm

they can aslo go back if you check and uncheck and check the temporary saved tweaks in Brush Preset.

karemuvar · June 23, 2024, 12:46am

Hi
I am getting this error when I open “new window” I do not seem to have it when I start Krita

Windows 11 / 5.2.3


A problem occurred in a Python script.  Here is the sequence of
function calls leading up to the error, in the order they occurred.

 C:\Users\USER\AppData\Roaming\krita\pykrita\CompactBrushToggler\CBT_Toggler.py in loadBrushInfo(self=<CompactBrushToggler.CBT_Toggler.CBT_Toggler object>)
  168         self.cur_size  = Krita.instance().activeWindow().activeView().brushSize()
  169 
  170         if cur_brush.name() != self.last_brush :
  171             self.resetBrushSetting()
  172             self.last_brush = cur_brush.name()
cur_brush = None
cur_brush.name undefined
self = <CompactBrushToggler.CBT_Toggler.CBT_Toggler object>
self.last_brush = 'kk brush A'
AttributeError: 'NoneType' object has no attribute 'name'
    __cause__ = None
    __class__ = <class 'AttributeError'>
    __context__ = None
    __delattr__ = <method-wrapper '__delattr__' of AttributeError object>
    __dict__ = {}
    __dir__ = <built-in method __dir__ of AttributeError object>
    __doc__ = 'Attribute not found.'
    __eq__ = <method-wrapper '__eq__' of AttributeError object>
    __format__ = <built-in method __format__ of AttributeError object>
    __ge__ = <method-wrapper '__ge__' of AttributeError object>
    __getattribute__ = <method-wrapper '__getattribute__' of AttributeError object>
    __gt__ = <method-wrapper '__gt__' of AttributeError object>
    __hash__ = <method-wrapper '__hash__' of AttributeError object>
    __init__ = <method-wrapper '__init__' of AttributeError object>
    __init_subclass__ = <built-in method __init_subclass__ of type object>
    __le__ = <method-wrapper '__le__' of AttributeError object>
    __lt__ = <method-wrapper '__lt__' of AttributeError object>
    __ne__ = <method-wrapper '__ne__' of AttributeError object>
    __new__ = <built-in method __new__ of type object>
    __reduce__ = <built-in method __reduce__ of AttributeError object>
    __reduce_ex__ = <built-in method __reduce_ex__ of AttributeError object>
    __repr__ = <method-wrapper '__repr__' of AttributeError object>
    __setattr__ = <method-wrapper '__setattr__' of AttributeError object>
    __setstate__ = <built-in method __setstate__ of AttributeError object>
    __sizeof__ = <built-in method __sizeof__ of AttributeError object>
    __str__ = <method-wrapper '__str__' of AttributeError object>
    __subclasshook__ = <built-in method __subclasshook__ of type object>
    __suppress_context__ = False
    __traceback__ = <traceback object>
    args = ("'NoneType' object has no attribute 'name'",)
    name = 'name'
    obj = None
    with_traceback = <built-in method with_traceback of AttributeError object>

The above is a description of an error in a Python program.  Here is
the original traceback:

Traceback (most recent call last):
  File "C:\Users\USER\AppData\Roaming\krita\pykrita\CompactBrushToggler\CBT_Toggler.py", line 170, in loadBrushInfo
    if cur_brush.name() != self.last_brush :
AttributeError: 'NoneType' object has no attribute 'name'

kaichi1342 · June 23, 2024, 2:54am

I really should go and run a full check of my plugins .

This is noted, thank you. I’ll see if I can patch within the week.

karemuvar · August 14, 2024, 4:35pm

Hi

Were you able to figure out what the problem was?

wakocima · October 18, 2024, 9:00am

Hi! Popping in, as I remembered using this plugin a good while ago, but now whenever I use it, well…

This happens. A constant error pop-up, every time I change to a different brush preset. I’m honestly not tech-savvy enough yet to comprehend what is going on there, but leaving it here in case someone had a similar issue!

[ I’m not sure if this relates to the previous bugs encountered in this thread ]

Using Krita 5.3 on Win 11

Michelist · October 18, 2024, 10:16am

Do you use the most recent version of this plugin, it was updated 8 months ago?

Michelist