I have been using this on krita 5 beta 2 for a while and it’s really handy, though it has some bugs like not detecting that a brush is using the pen for opacity. But good job on it
Neat plugin thank you!
I copy pasted the Overlay Mode lines and added Color Rate as well since I somewhat regularly change it to 0 with the right click popup palette when painting with smudge brushes. Also changed the button colours to fit my Krita theme better.
Bug I ran into:
Brush size/color rate/flow/etc get reset if it was changed with popup palette sliders or shift drag unless the Brush Editor is open (which affects brush performance negatively when painting).
there are couple of things i cant really do with the plugin,
one of them is reflecting a change from - brush editor / i tried but it was like trying to outrace it.
Ill check on the case with pop up pallet change afaik, the plugin only affect change if you click on it.
OTH - i dont really want to add so much on to it, since the foundation code is rather hackish and i think inefficient in the long run. [it walks the brush editor tree till it find the checkbox]
My wish is to hopefully redo this, this time by extending on krita code and directly calling the toggles instead of locating checkboxes and checking them.
I look into adding the Color Rate tonight so that they are aligned, since right now there are three things to check.
does the property has check box on the list and a checkbox on the panel?
does it only has checkbox on the panel?
does it only has checkbox on the list but not on the panel.
edit: Saw the bug - noted. Ill try see if i can mitigate it. Seems that it only happen if things are change in popup but not from settings in the toolbar.
OTH i found a weird behaviour with toolbar controls and popup pallete value.
Hello I think i manage to atleast make sure the value dont reset. Now this only works when palette is close when toggle. Ill test it some more once i get back to work and clean up my code.
Why? I think there is a bug with the interaction of brush editor to the palette that has nothing to do with the plugin . i will be filing a bug report on this.
i.e.
Open Popup Pallete
Open Brush editor,
Change the value one of the following slider;
Size, Opacity, smudge length, Color rate;
watch how the slider in the pallete will only have 3 value depending on where the slide is in the editor.
0 or .50 or 1
Hello, here’s the fix. kinda. I have not merge it yet, need to update the doc. [also added color rate]
I only resolve it for the more common setting in the palette. I don’t think I will be able to catch all of them.
In a way I understand the palette - editor function and learned the following.
Changes in the palette are not reflected directly to the editor i think until the editor have been open.
That’s the trickiest part. This plugin function by walking the editor.
Changing value from editor does not reflect well to the palette.
This fix is pretty hacky, imo.
I think it’s in the life of it that i should really start studying rewriting it - and extending some krita functions.
can you comment if there is a slow down. I think my pc cant truly reflect the effect of all those traversing on performance.
Tested and I have to open the brush editor once every time I change the brush values for it to stick.
I also noticed the values only get reset if the brush is using a texture brush tip (Predefined tab). (both in this update and master)
Yes, for me the canvas rendering stutters and gets worse after some time. (macOS 10.13.6, Krita 5.0.2) Sometimes it takes a while before any stutter appears though.
I’ll also have to disable the plugin when sketching and frequently change between pencil and eraser brush since there is a little bit of hiccup every time. Acceptable tradeoff for when painting and I change brush less often though. (master and this update)
OpenSUSE Tumbleweed, Krita 5.0.2, on same computer:
The canvas/cursor still stutter but the lines comes out smooth. The pause when changing brush also happen but krita still records brush strokes during the pause and catch up thereafter unlike on macOS.
(I’ve got a Windows 10 install as well if you want me to try it there too.)
I found some help in the Krita Manual (Managing Python Plugins) on how to manually install a plugin (a bit like the manual process for Blender), and got the Compact Brush Toggler running.