Buli Brush Switch

[Grum999]

@AndreasResch

I was not able to assign “B” and “E” (as they were already used by the default tools). Is there a way to overwrite the original key bindings without having to delete them first. Would make it a bit easier to use for first time users. Maybe a checkbox or a button like “Override default shortscuts” would be a option as well.

Probably possible… but as I already tweaked a bit the shortcut system, I don’t feel comfortable to override an existing shortcut…
I’m adding this to the TODO list, at least to test if it’s possible and check results…

@AndreasResch

When I deselect “Ignore eraser mode” in the brush settings of the plugin and click “OK”, it’s still there then next time I open the dialog.

That’s clearly a regression.
I need to check that.

@AndreasResch

Trying to close the brush settings window by clicking the “X” of the dialog, doesn’t work.

I have to test on windows, on Linux I don’t have the problem

@AndreasResch

There seems to be a little discrepancy in the icon display.

Yes, current toolbar button is a cosmetic improvement I have in the todo list; currently not a big issue to use the plugin, so I keep that for later

@AndreasResch

Here I’m painting right now, yet your icon shows the eraser. Shouldn’t they be the same?

Icon is showing brush according to defined Button selection mode option

@AndreasResch

Also what’s the purpose of the button of you plugin being blue once I click it?

When it’s blue, it means the current brush has been selected from plugin, and plugin is currently active to manage brush
When it’s not blue, it means the plugin is not active and Krita manage the brush

More information on Brush selection
But maybe I’ve to rewrite it
I wrote documentation quickly

@AndreasResch

I hope this makes sense.

The plugin works in a simple way.

Select a brush from plugin: plugin is active (button is highlighted in blue)
Select a brush from Krita: plugin is inactive (button is not highlighted in blue anymore)

So, to activate plugin you can:

• Use shortcut
• Click on brush in brush list
• Click on icon in toolbar

So, to deactivate plugin you can:

• Use general shortcut (if it has been defined)
• Use the same shortcut than current plugin active brush
• Click on active brush in brush list
• Click on icon in toolbar

When plugin is active, brush properties defined by plugin are applied.
When plugin is deactivated, all change made on brushes are discarded:

• Krita’s last brush values (size, opacity, color, …) are restored with their values
• Plugin’s brush values are reset to the default one defined in brush setting (modulo some exception defined by options)

So once plugin is inactive (for example, you’ve selected another eraser from Krita’s presets) that’s normal that hitting shortcut “E” activate the default eraser from plugin again (if shortcut “E” has been affected to plugin default eraser brush)

The plugin is not aimed to memorize the last used brush.
I’m telling it’s not possible to implement, as it’s possible through option to keep in memory for a brush changes made for color/tool/size/opacity/… it’s possible to add an option to tell “for this brush definition, when user change Brush from Krita, keep it in memory and don’t deactivate plugin”
=> I put it on my TODO list (but clearly that’s something I’ll probably never use - too complicated to my brain to change brushes all the time, I need fixed things to not be lost )

Just for now, I already spent too much time for this plugin, I already promised few weeks ago -before starting to work on this plugin- to improve JPEG Export plugin.
I also have other plugins on which I stopped everything

So I’ll work on another stuff and come back on this one in one week or two.
Need also more feedback from users, maybe there’s some other bugs to fix, things to improve, or different point of view to take in account.
And it will be better and easier (for me) to spent few days of work on one plugin than working on many plugins at the same time

Grum999

[TheTwo]

I think it can include gradient, fill and colorize mask tools. Although it doesn’t make sense in most cases, there are also situations where erasing is necessary.

[AndreasResch]

Don’t worry. It works once you click all the buttons in the right order. You just have to get used to that routine before starting to work. There’s only the little risk, that people might shy back from using it, because it’s just too confusing as it is now.

[Grum999]

Hi

@Gremriel

here’s a OneDrive link

I just took a quick look.

The problem is clearly from the database resource file, I can get errors too

Resources name in your old database were stored with underscores, and for what I understood, it’s not normal.

@tiar

but names are saved into the databases with spaces.

(from this post on which weird things occurred with BuliNote due to invalid resources from database, Buli Notes - #66 by tiar)

Underscores has been replaced by spaces at a moment.

For what I can see, your database has been created with a Krita 5.0.0-prealpha; so for what I can tell and understood, your database has been built with a version of Krita, and now using a krita version that is not “totally compatible” anymore (at least, plugin is clearly not compatible )

So I won’t spent too much time on this case: reset database fix the problem, and it’s recommended for whom use “very old” Krita 5 database to reset it:

Buli Notes

This is a recent change, for brush presets, underscores are now replaced with spaces in the “internal” name too, but doesn’t force recreation of the database. So everyone using a nightly build, please delete your resourcecache.sqlite. I was also wondering why the preset history is broken once again…

Grum999

[Grum999]

@TheTwo

I think it can include gradient, fill and colorize mask tools. Although it doesn’t make sense in most cases, there are also situations where erasing is necessary.

I already have to check what @dweller asked me:

Buli Brush Switch

Thank you very much! Coding a new option seems like a lot of work for me because I have no knowledge of coding the sources for a brush: [image] if you click the 'mix" in the color box, you can mix plain color (foreground/background) or gradient. here is a use case of my grass brush. [image] with a gradient option, you can choose specific colors to make the blending more “beautiful” but the foreground/background option can work too. I think it will take longer for me to cha…

Is it related?

Could you be more precise?
I really have difficulties to understand relation ship between brushes, gradient fill, fill, mask tools…

Grum999

[Grum999]

@AndreasResch

it’s just too confusing as it is now

I have to write better documentation
Myself I’m not really satisfied with what I wrote, but writing good documentation takes times and english is not my native language, so sometimes it’s very hard to explain things

But in my logic, plugin is simple to use
After between what I’ve implemented and what you was expecting about how user interface would be, it can be harder to understand what I’ve implemented…

Grum999

[AndreasResch]

Let’s say the complexity fits Krita very well And the easier the plugin is to understand, the less time you have to spend on documentation. Maybe also something to consider. I’d rather use a plugin than to dig through a documentation to understand it.

[SchrodingerCat]

Why not make a short video showing how it works?

Sometimes seeing is better than reading.

[TheTwo]

@Grum999

I really have difficulties to understand relation ship between brushes, gradient fill, fill, mask tools…

These tools inherit the blending mode of the brush

[Grum999]

@TheTwo

These tools inherit the blending mode of the brush

In other words?
Your explanation is not understandable for someone like me that don’t understand what we are talking about.

Please even if I’m used to help people here I don’t have an absolute knowledge of Krita, and especially brushes are one thing that for miscellaneous reason I usually don’t look at…

Is it so difficult to provide some detailed explanation?
An example of what a “mask tools” is?
What is the “fill”? the fill tool?

How to use it with brush?

Which brushes I can use and what situation I can reproduce to modify this “mask tool” or “fill”?
Screenshots are always welcome too

I’m open to try to improve plugin, but I can’t guess what people have in their mind.
A minimum explanation and example is needed

Also, I didn’t really had time to took a look on examples provided from @dweller so maybe it’s the same thing, I don’t know.
But here I don’t have the time to search to understand what is asked to implement…

Short story about relationship between developers and users

At the office, few days ago, business users weren’t happy to see that in new the Excel file produced by accounting software, there was only 3 worksheets.

• “Where is the 4th worksheet!?” they’ve asked
• “Which 4th worksheet are you talking about?”
• “We should have 4th worksheets in the excel file! One is missing!”
• (Looking business requirement document -BRD- provided by business to developers)
  “In BRD, it’s asked for 3 worksheets only”
• “Yes, and what? you should have understood that we need 4 worksheets”

Grum999

[dweller]

I think @TheTwo is talking about tools of krita. In my earlier post, I talked about the option for the brush to use gradients for its color. When a brush uses gradient, it cannot be used like the gradient tool, just use the colors in the gradient. I think this explains a lot better than my words

you can try this brush

short_green_grass_1.kpp

I made it because I use my mouse.

you can choose a gradient here and try out different colors. you can ask me more questions too if you have any.

[Grum999]

@dweller

you can try this brush

Many thanks!

I’ve downloaded it, and saved it with my TODO document for this plugin.
I’ll take a look on it to understand how it works and what can be done to take this in account.

Grum999

[Grum999]

@SchrodingerCat

Why not make a short video showing how it works?

That’s an idea.

Need to take time for that…

Grum999

[TheTwo]

Sorry, I always simplify statements because I am not good at English.I also thought that the following words were not asking me……

I was suggesting adding more tools to “use speciic paint tool”.

For “gradient fill” and “fill”, attributes such as brush strokes are no longer important. But these two tools will use the blending mode of the selected brush. For example: you select an “eraser” brush, “gradient fill” and “fill” will become erased pixels. There are also some other combination methods, such as a radial gradient plus a brightening blending mode to form a luminous preset

For the colorize mask tool, it simply clicks to create a corresponding mask layer. Then use the brush of your choice

My understanding is that “brush” is a sub-tool of “tool”. The tool for drawing pixels has been using various settings of the brush (even when you want to draw a rectangle, you need to choose a suitable brush)
I think there may be an integrated resource in the future, integrating tool opinions and brushes (gradient should be integrated inside the brush, for tip and source)

[Grum999]

@TheTwo

Sorry, I always simplify statements because I am not good at English.

I’m not really good with english too, often need to be helped with google

@TheTwo

I also thought that the following words were not asking me……

No worries

@TheTwo

I was suggesting adding more tools to “use speciic paint tool”.

For “gradient fill” and “fill”, attributes such as brush strokes are no longer important. But these two tools will use the blending mode of the selected brush.

@TheTwo

My understanding is that “brush” is a sub-tool of “tool”.

Basically, when a brush is selected, the plugin just:

• Select brush from presets
• Update some properties like size, opacity, color (according to what is defined on brush settings)
• Activate the tool if one is defined

In tool list, I only defined tools that directly use current selected brush to draw.

Gradient tool, Colorize mask tool, Fill tool depend of color or gradient color, but are not really related to current brush.

I think adding it to this plugin would be more confusing.

I mean, does it make sense to select fill tool when choosing a brush?

Also:

@TheTwo

integrating tool opinions and brushes

This merge request is interesting.

I understand the idea of quick access to some predefined tools settings.

So, does it make sense to select fill tool when choosing a brush?
→ No

Do it make sense to have some tools like fill tool or selection tool with some predefined preset
→ Yes

But for me it’s more another plugin, or an extension of current plugin:

• having a dedicated button for tools
• having a dedicates window settings for tools

But if there’s a WIP for an integrated user interface in Krita about that, it’s better to wait for it
Especially if the docker allows to define presets for tools and these preset could be accessible through API, maybe plugin can add something more, I don’t know.

Grum999

[TheTwo]

@Grum999

Gradient tool, Colorize mask tool, Fill tool depend of color or gradient color, but are not really related to current brush.

I think adding it to this plugin would be more confusing.

I mean, does it make sense to select fill tool when choosing a brush?

Colorize mask tool can correspond to different brushes. It does not only support round pens.
I don’t think there will be confusion, it just has three more options. People don’t understand that it is not the reason for the plug-in, but the way krita works. At best, they avoid options that they don’t understand.
Conversely, it can also be understood as “choose a brush when selecting fill tool”.As mentioned earlier: “brush” is a sub-tool of “tool”. It is the same whether you choose a brush or a tool first. They are not separated.
For gradient, there can be radial light effects and linear erasure. For fill, it is mainly erasure, especially the upcoming improvements in version 5.1

@Grum999

But if there’s a WIP for an integrated user interface in Krita about that, it’s better to wait for it
Especially if the docker allows to define presets for tools and these preset could be accessible through API, maybe plugin can add something more, I don’t know.

I have never used it. My guess is that it only contains tool opinions and does not bind the brush.
It may be possible to bind through plug-ins, (some off-topic) but my final idea is to use it as a resource type. It includes tools, tool opinions and brushes (brushes contain gradients). In this way, we can share things like “line brushes with different anti-shake”, “circles formed by petals”, “gradients erased from the outside to the inside” and so on. Krita has the ability to combine freely, but lacks the means to group them and share them.

[JoseConseco]

I was wondering if it is possible to assign multiple brushes per hotkey (it would behave as cyclic list - where each tap at hotkey. goes to next item).
This way we could eg have something like this:

• ‘1’ key → cycles through one or more pencil brushes
• ‘2’ key - we cycle through paint brushes
• ‘3’ - we cycle through FX brushes (or texture brushes) etc.
  This way if user assigns one brush per hotkey it would behave ‘old’ way, but if you assign more than one then we could have cyclic brush list behavior.

[dudles_82]

Love this, hope they implement it in the official program

[tachiko]

@JoseConseco

I was wondering if it is possible to assign multiple brushes per hotkey

Switch to Alternate Version of Brush Plugin

Switch to Alternate Version of Brush Plugin

This plugin adds a shortcut to switch between brush preset that has the similar name (any brush preset with a shared name before “[”, “Paintbrush”, “Paintbrush [1]”, “Paintbrush [2]”, “Paintbrush [Wet]”). The brush name before “[” or " [" have to be the same. Download The original purpose of this plugin was to change between different brush angle. Since apparently changing brush tip angle via python is not possible. I made this plugin to switch between the brush preset and its duplicates with …

[TheTwo]

An error occurred today after I disabled some bundles. Every time krita starts, it will jump out several times.

I only put two brushes in it. I guess it’s the bug caused by the disappearance of one brush. After recovery, the plug-in will no longer report errors.

However, it is troublesome to modify the plug-in every time you operate the bundle…

TypeError
Python 3.8.1: C:\GAMES\STEAM\steamapps\common\Krita\krita\bin\krita.exe
Tue May  3 12:08:49 2022

A problem occurred in a Python script.  Here is the sequence of
function calls leading up to the error, in the order they occurred.

 C:\Users\123\AppData\Roaming\krita\pykrita\bulibrushswitch\bbs\bbswbrushes.py in data(self=<bulibrushswitch.bbs.bbswbrushes.BBSBrushesModel object>, index=<PyQt5.QtCore.QModelIndex object>, role=1)
  946                 if column==BBSBrushesModel.COLNUM_ICON:
  947                     # QIcon
  948                     return QIcon(QPixmap.fromImage(item.image()))
  949         elif role == Qt.ToolTipRole:
  950             id=self.__items[row]
global QIcon = <class 'PyQt5.QtGui.QIcon'>
global QPixmap = <class 'PyQt5.QtGui.QPixmap'>
QPixmap.fromImage = <built-in function fromImage>
item = <BBSBrush(4487ff9d-99b7-44ba-b244-23f9c6b58275, @ A Base color, #ffffff)>
item.image = <bound method BBSBrush.image of <BBSBrush(4487ff...4ba-b244-23f9c6b58275, @ A Base color, #ffffff)>>
TypeError: fromImage(QImage, flags: Union[Qt.ImageConversionFlags, Qt.ImageConversionFlag] = Qt.AutoColor): argument 1 has unexpected type 'NoneType'
    __cause__ = None
    __class__ = <class 'TypeError'>
    __context__ = None
    __delattr__ = <method-wrapper '__delattr__' of TypeError object>
    __dict__ = {}
    __dir__ = <built-in method __dir__ of TypeError object>
    __doc__ = 'Inappropriate argument type.'
    __eq__ = <method-wrapper '__eq__' of TypeError object>
    __format__ = <built-in method __format__ of TypeError object>
    __ge__ = <method-wrapper '__ge__' of TypeError object>
    __getattribute__ = <method-wrapper '__getattribute__' of TypeError object>
    __gt__ = <method-wrapper '__gt__' of TypeError object>
    __hash__ = <method-wrapper '__hash__' of TypeError object>
    __init__ = <method-wrapper '__init__' of TypeError object>
    __init_subclass__ = <built-in method __init_subclass__ of type object>
    __le__ = <method-wrapper '__le__' of TypeError object>
    __lt__ = <method-wrapper '__lt__' of TypeError object>
    __ne__ = <method-wrapper '__ne__' of TypeError object>
    __new__ = <built-in method __new__ of type object>
    __reduce__ = <built-in method __reduce__ of TypeError object>
    __reduce_ex__ = <built-in method __reduce_ex__ of TypeError object>
    __repr__ = <method-wrapper '__repr__' of TypeError object>
    __setattr__ = <method-wrapper '__setattr__' of TypeError object>
    __setstate__ = <built-in method __setstate__ of TypeError object>
    __sizeof__ = <built-in method __sizeof__ of TypeError object>
    __str__ = <method-wrapper '__str__' of TypeError object>
    __subclasshook__ = <built-in method __subclasshook__ of type object>
    __suppress_context__ = False
    __traceback__ = <traceback object>
    args = ("fromImage(QImage, flags: Union[Qt.ImageConversio...Color): argument 1 has unexpected type 'NoneType'",)
    with_traceback = <built-in method with_traceback of TypeError object>

The above is a description of an error in a Python program.  Here is
the original traceback:

Traceback (most recent call last):
  File "C:\Users\123\AppData\Roaming\krita\pykrita\bulibrushswitch\bbs\bbswbrushes.py", line 948, in data
    return QIcon(QPixmap.fromImage(item.image()))
TypeError: fromImage(QImage, flags: Union[Qt.ImageConversionFlags, Qt.ImageConversionFlag] = Qt.AutoColor): argument 1 has unexpected type 'NoneType'

AttributeError
Python 3.8.1: C:\GAMES\STEAM\steamapps\common\Krita\krita\bin\krita.exe
Tue May  3 12:09:29 2022

A problem occurred in a Python script.  Here is the sequence of
function calls leading up to the error, in the order they occurred.

 C:\Users\123\AppData\Roaming\krita\pykrita\bulibrushswitch\bbs\bbswbrushes.py in paint(self=<bulibrushswitch.bbs.bbswbrushes.BBSBrushesModelDelegate object>, painter=<PyQt5.QtGui.QPainter object>, option=<PyQt5.QtWidgets.QStyleOptionViewItem object>, index=<PyQt5.QtCore.QModelIndex object>)
 1356                 painter.fillRect(option.rect, option.palette.color(QPalette.Highlight))
 1357 
 1358             painter.drawPixmap(option.rect.topLeft(), index.data(Qt.DecorationRole).pixmap(option.decorationSize))
 1359             painter.restore()
 1360             return
painter = <PyQt5.QtGui.QPainter object>
painter.drawPixmap = <built-in method drawPixmap of QPainter object>
option = <PyQt5.QtWidgets.QStyleOptionViewItem object>
option.rect = PyQt5.QtCore.QRect(0, 99, 32, 394)
option.rect.topLeft = <built-in method topLeft of QRect object>
index = <PyQt5.QtCore.QModelIndex object>
index.data = <built-in method data of QModelIndex object>
global Qt = <class 'PyQt5.QtCore.Qt'>
Qt.DecorationRole = 1
).pixmap undefined
option.decorationSize = PyQt5.QtCore.QSize(32, 32)
AttributeError: 'NoneType' object has no attribute 'pixmap'
    __cause__ = None
    __class__ = <class 'AttributeError'>
    __context__ = None
    __delattr__ = <method-wrapper '__delattr__' of AttributeError object>
    __dict__ = {}
    __dir__ = <built-in method __dir__ of AttributeError object>
    __doc__ = 'Attribute not found.'
    __eq__ = <method-wrapper '__eq__' of AttributeError object>
    __format__ = <built-in method __format__ of AttributeError object>
    __ge__ = <method-wrapper '__ge__' of AttributeError object>
    __getattribute__ = <method-wrapper '__getattribute__' of AttributeError object>
    __gt__ = <method-wrapper '__gt__' of AttributeError object>
    __hash__ = <method-wrapper '__hash__' of AttributeError object>
    __init__ = <method-wrapper '__init__' of AttributeError object>
    __init_subclass__ = <built-in method __init_subclass__ of type object>
    __le__ = <method-wrapper '__le__' of AttributeError object>
    __lt__ = <method-wrapper '__lt__' of AttributeError object>
    __ne__ = <method-wrapper '__ne__' of AttributeError object>
    __new__ = <built-in method __new__ of type object>
    __reduce__ = <built-in method __reduce__ of AttributeError object>
    __reduce_ex__ = <built-in method __reduce_ex__ of AttributeError object>
    __repr__ = <method-wrapper '__repr__' of AttributeError object>
    __setattr__ = <method-wrapper '__setattr__' of AttributeError object>
    __setstate__ = <built-in method __setstate__ of AttributeError object>
    __sizeof__ = <built-in method __sizeof__ of AttributeError object>
    __str__ = <method-wrapper '__str__' of AttributeError object>
    __subclasshook__ = <built-in method __subclasshook__ of type object>
    __suppress_context__ = False
    __traceback__ = <traceback object>
    args = ("'NoneType' object has no attribute 'pixmap'",)
    with_traceback = <built-in method with_traceback of AttributeError object>

The above is a description of an error in a Python program.  Here is
the original traceback:

Traceback (most recent call last):
  File "C:\Users\123\AppData\Roaming\krita\pykrita\bulibrushswitch\bbs\bbswbrushes.py", line 1358, in paint
    painter.drawPixmap(option.rect.topLeft(), index.data(Qt.DecorationRole).pixmap(option.decorationSize))
AttributeError: 'NoneType' object has no attribute 'pixmap'