I recently submitted a merge request to the Krita repository where I’ve improved the Quick Settings Docker.
The update adds buttons for adding and removing presets from the list and introduces persistence, so it now works more like what Clip Studio Paint offers.
This is the merge request for it, along with a more detailed description:
This is actually my first time contributing to open source and to Krita in general. I haven’t received any review or feedback on the request yet, so I thought I’d share it here to get in touch with the community and hopefully get some eyes on it.
I’d really appreciate any feedback, thoughts, or testing. Thanks for your time!
Yeah, that happens a lot since the main branch changes every few days most merge requests end up out of date fast. I just wanted to see if it usually takes a while to get reviewed or if posting here helps get some attention on it.
A developer will look at it when they have time. What you can do here already is ask artists to test it and give feedback. They will probably do so quicker than a developer will look at it and might find bugs or other issues. See here on how to grab the builds for that: How to test a Merge Request or a new, unfinished feature [Instruction]
It’s not a big deal, but in the future please don’t merge the upstream branch (master, in this case) into your branch. You don’t need to manually update your branch at all unless there is conflicts or you need the update from upstream, otherwise you just strain the build servers for no reason. If there are conflicts, you gotta rebase your branch onto the upstream branch, not reverse-merge the upstream on top of yours. Please don’t try to fix it now though, it’s already too late and would trigger another pointless build, it can be corrected the next time you need to make an edit or it’s supposed to be merged.
Sorry for the question, but where or when can it be accessed? Is it already in the PLUS or NEXT nightlies or can I download it from Gitlab? Is it the qt6guiprivate-attempt2.zip? It seems I’m too stupid to discover its download location, find a clue. Or must I build it myself? Which would be out of my abilities.
But I guess that this, together with @Toma_Omito’s Quick Access Manager which already offers a lot of this CSP functionality as a plugin, plus @Script Kiddy's (whose forum handle, if existent, is unknown to me) Workflow Buttons (already in the Krita Next nightlies), plus @yetanotherpainter’s Actuator (paid!), and if you want to go into extreme-tuning plus @CarWalTech’s Touchify, will put Krita on steroids!
Okay, Krita is already flying high, but all these combined intelligently may be the next booster …
I built it using the Krita 5.3 version that is not yet released so if it gets merged soon it will be accessible in the next Krita version. To access it you don’t have to build anything right now, I have already built a few versions.
I will post screenshots with the steps to access it.
Step 1: Go on the link and click on Pipelines
The warning just means that the branch is behind master; usually you don’t need to do anything about that, the reviewer will trigger the Rebase if needed. If there were any conflicts, it would say that there are conflicts; but it only says “fast-forward merge is not possible” which is fine, because that’s what’s expected for anything not updated literally the same day (it gets outdated often very soon after updating, so it’s not a cause for concern, usually the commits aren’t related and aren’t even changing the same files, so Rebase works automatically without issues).
I added the “Needs Review” label (I think Dmitry checks out new MRs without that label too since volunteers usually don’t have permissions to set labels, unfortunately, but it’s still good to have it labeled).
And I removed the merge commit and rebased it manually (and changed some commit message titles to refer to Quick Settings Docker explicitely), triggering that unnecessary pipeline run. In my defense, the initial pipeline run was also unnecessary since it’s just changes in Python. @Michelist in this particular MR, you could’ve just copied the file and put it in the Quick Settings Docker code directory; but it is easier to just grab the build from the pipeline.
And also added some comments in regards to code. I haven’t built it and checked the docker out myself yet.
The changes do sound good though! Thanks for working on it.
